[PATCH] D45075: Improve error message for an unknown --plugin-opt.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 10:20:09 PDT 2018


ruiu added inline comments.


================
Comment at: lld/ELF/Driver.cpp:609
+  const char *Argv[] = {Config->ProgName.data(), Opt.data()};
+  if (cl::ParseCommandLineOptions(2, Argv, "", &OS))
+    return;
----------------
grimar wrote:
> I would probably add `...,/*Overview=*/"", ...)` as I had to look what this parameter is.
I honestly don't think that's helpful because we don't explain what is "Overview" after all (and even I don't know what it is.)


https://reviews.llvm.org/D45075





More information about the llvm-commits mailing list