[PATCH] D45003: [Support] Make line-number cache robust against access patterns.

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 09:58:20 PDT 2018


jordan_rose added a comment.

That seems about as clever as possible—anything more and it would definitely be overboard. Can you add tests with 255-, 256-, and 257-byte buffers, then? With and without newlines as the last character, and testing the just-past-the-end pointer in addition to something in-bounds?


Repository:
  rL LLVM

https://reviews.llvm.org/D45003





More information about the llvm-commits mailing list