[PATCH] D44848: Align stubs for external and common global variables to pointer size.

[Rahul Chaudhry via Phabricator via llvm-commits]

rahulchaudhry marked an inline comment as done.
rahulchaudhry added a comment.

Thanks for the review.
If everything looks good, can you land it as well.
This is my first change. I don't have write permissions to the repo.



================
Comment at: test/CodeGen/X86/catch.ll:8
+; The stub symbol should have pointer-size (8 byte) alignment.
+; CHECK:      .data{{[[:space:]]}} .p2align 3
+; CHECK-NEXT: .L.Lstr.DW.stub:
----------------
espindola wrote:
> Nit, the p2align is in another line, no? Could you use CHECK-NEXT?
There were multiple .data directives in the original test, and I was trying to match the one preceding p2align.
In this case, there's only one .data, so simple CHECK/CHECK-NEXT sequence works fine.


Repository:
  rL LLVM

https://reviews.llvm.org/D44848