[PATCH] D44808: Fix lib.exe detection when running within MSVC toolchain

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/case-detection.test:7
+RUN: cp llvm-ar %t1/Lib
+RUN: %t1/Lib /OUT:%t.lib %t.obj
----------------
aganea wrote:
> rnk wrote:
> > WIll this pass on Windows without a .exe suffix?
> I was worried it wouldn't pass on a Unix box (which I don't have here), that's why I didn't add the .exe suffix.
> 
> I've tested on Windows 10, both in a MingW64 shell and a regular cmd.exe shell. Tested with Python 2.7 and 3.6. The test passes in all cases.
> 
> Would you like me to do other tests? Or do this step in a different manner?
@rnk - are you fine with the test? Or should I make it Windows-specific and use Lib.exe instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D44808