[PATCH] D44001: [SCEV] Prove implications for SCEVUnknown Phis

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9603
+    return true;
+  } else if (LPhi) {
+    if (!properlyDominates(RHS, LPhi->getParent()))
----------------
anna wrote:
> I think you can extract out the logic here into another lambda because there's a lot of code duplication.
> Really all we want to check using logic below and it can be extracted into `isImplied(PhiNode *Phi, const Scev *LHSOrRHS)`.
Dominance check is only needed in one case, so I don't think it's a good idea to make such a lambda.


https://reviews.llvm.org/D44001