[PATCH] D44848: Align stubs for external and common global variables to pointer size.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 29 17:18:14 PDT 2018


espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

Awesome :-)

LGTM.



================
Comment at: test/CodeGen/X86/catch.ll:8
+; The stub symbol should have pointer-size (8 byte) alignment.
+; CHECK:      .data{{[[:space:]]}} .p2align 3
+; CHECK-NEXT: .L.Lstr.DW.stub:
----------------
Nit, the p2align is in another line, no? Could you use CHECK-NEXT?


Repository:
  rL LLVM

https://reviews.llvm.org/D44848





More information about the llvm-commits mailing list