[PATCH] D44802: Add the ShadowCallStack pass

[Peter Collingbourne via Phabricator via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/X86/ShadowCallStack.cpp:94
+
+  auto MI = MBB.begin();
+  // mov r10, [rsp]
----------------
Nit: I'd call this `MBBI` because it might not actually point to a MachineInstr.


================
Comment at: lib/Target/X86/ShadowCallStack.cpp:121
+  // mov REG, [rsp]
+  if (MBB.empty())
+    addDirectMem(BuildMI(&MBB, DL, TII->get(X86::MOV64rm)).addDef(FreeRegister),
----------------
Looks like this can be simplified to `addDirectMem(BuildMI(&MBB, MBB.begin(), ...`


Repository:
  rL LLVM

https://reviews.llvm.org/D44802