[PATCH] D44963: ELF: Add support for short thunks on ARM.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

Thank you for writing the comment. That improved the code quality a lot.



================
Comment at: lld/ELF/Thunks.cpp:85
+  // the layout from converging.
+  bool MayUseShortThunk = true;
+
----------------
Should this be private to make it clear that only mayUseShortThunk() is a public interface?


================
Comment at: lld/ELF/Thunks.cpp:272
+  if (S & 1)
+    return MayUseShortThunk = false;
+  uint64_t P = getThunkTargetSym()->getVA();
----------------
Could you write assignment and return in separate lines?


https://reviews.llvm.org/D44963