[PATCH] D43916: Named VReg support for MIR

[Puyan Lotfi via llvm-commits]

Could this bit be in a subsequent patch?
Right now im not exactly sure what the right way to go about this is because you have a vreginfos but they are named in much the way physregs are named. The named physregs have the map in MIParser. Still thinking of the right way to do this.

PL


​Sent with ProtonMail Secure Email.​

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On March 29, 2018 4:28 AM, Francis Visoiu Mistrih via Phabricator <reviews at reviews.llvm.org> wrote:

> thegameg added inline comments.
> 
> 
> ===================================
> 
> Comment at: lib/CodeGen/MIRParser/MIParser.cpp:145
> 
> -   /// Maps from virtual register names to virtual registers.
>     
> -   StringMap<unsigned> Names2VRegs;
>     
>     /// Maps from register mask names to register masks.
>     
> 
> I still think this should be merged with `VRegInfosNamed` in this patch, and end up with something like:
> 
> `DenseMap<std::string, VRegInfo*> VRegInfosNamed;`
> 
> Repository:
> 
> rL LLVM
> 
> https://reviews.llvm.org/D43916