[PATCH] D44838: [X86] Correct the placement of ReadAfterLd in BEXTR and BZHI

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 29 08:54:53 PDT 2018


andreadb added inline comments.


================
Comment at: lib/Target/X86/X86ScheduleZnver1.td:573
+def : InstRW<[WriteALULd, ReadDefault, ReadDefault, ReadDefault, ReadDefault,
+              ReadDefault, ReadAfterLd], (instregex "BEXTR(32|64)rm")>;
 
----------------
You can just enumerate opcodes using `(instrs BEXTR32rm, BEXTR64rm)`.


================
Comment at: lib/Target/X86/X86ScheduleZnver1.td:580
+def : InstRW<[WriteALULd, ReadDefault, ReadDefault, ReadDefault, ReadDefault,
+              ReadDefault, ReadAfterLd], (instregex "BZHI(32|64)rm")>;
 
----------------
Same. You can use `(instrs BZHI32rm, BZHI64rm)`.


https://reviews.llvm.org/D44838





More information about the llvm-commits mailing list