[PATCH] D44899: [ELF] - Print LMA in a -Map file.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/MapFile.cpp:50
   int W = Config->Is64 ? 16 : 8;
-  OS << format("%0*llx %0*llx %5lld ", W, Addr, W, Size, Align);
+  OS << format("%*llx %*llx %*llx %5lld ", W, VMA, W, LMA, W, Size, Align);
 }
----------------
ruiu wrote:
> Can you change this to 
> 
>   "%*llx %9llx %*llx %5lld "
> 
> ? I think size 16^9 should be enough for any section.
64Gb? Maybe. It's not 640kb at least.

I thought about dynamic column's width though.
I prepared a patch for that: D45018.


https://reviews.llvm.org/D44899