[PATCH] D43347: [ELF][MIPS] Support linking of PIE for MIPS
Simon Atanasyan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 29 00:06:01 PDT 2018
atanasyan added inline comments.
================
Comment at: test/ELF/mips-dynamic.s:63
+# EXE-DAG: 0x70000035 MIPS_RLD_MAP_REL 0x{{[0-9A-F]+}}
# EXE: ]
----------------
grimar wrote:
> I think that this test case, for example, does not really check that
> DT_MIPS_RLD_MAP is not emitted for PIE.
>
> Problem is that `*-NEXT` and/or `*-NOT` are not used and check tags are
> mixed, what is a bit hard to read.
>
> I would suggest explicitly testing `DynamicSection` twice, one time with
> use of `PIE`/`PIE-NEXT` and the second time with `NOPIE`/`NOPIE-NEXT`
> to show which tags are produced for each case.
> I would suggest explicitly testing DynamicSection twice
Good point. Thanks.
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D43347
More information about the llvm-commits
mailing list