[PATCH] D44775: [ELF] - Fill executable segments with trap instructions.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/Writer.cpp:2193
+
+void fillTrap(uint8_t *I, uint8_t *End) {
   for (; I + 4 <= End; I += 4)
----------------
Why not static?


================
Comment at: ELF/Writer.cpp:2221
+    for (size_t I = 0; I < V.size() - 1; ++I)
+      fillTrap(Buf + V[I]->Offset + V[I]->Size, Buf + V[I + 1]->Offset);
+
----------------
I wonder if we could write this as we write the sections.


https://reviews.llvm.org/D44775