[PATCH] D44282: [PR16756] JumpThreading: explicitly update SSA rather than use SSAUpdater.

[Daniel Berlin via llvm-commits]

I'm ... confused.


On Wed, Mar 28, 2018 at 4:33 PM, Michael Zolotukhin via Phabricator <
reviews at reviews.llvm.org> wrote:

> mzolotukhin added a comment.
>
> > I don't mind this approach, but as discussed offline we should consider
> also moving LCSSA to make sure the API makes sense.
> >  In general, what's your plan for this? You want it to replace the SSA
> updater for all the instances in llvm? If so, we should carefully plan the
> transition costs.
>
> I looked into LCSSA, and indeed it seems that it also can be improved. I
> tried direct replacement of the old SSAUpdater with the new one, but that
> didn't give any benefits.


Before you said "(although the new implementation still was significantly
faster than the existing one)"
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180328/f24d63c0/attachment.html>