[PATCH] D44214: Improve --warn-symbol-ordering.

Rafael Ávila de Espíndola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 16:05:59 PDT 2018


rafael added a comment.

>>> > This will now fire on symbols the linker defines relative to an output section, no?
>>  > > 
>>  > That would be a good thing, right? Attempting to order a symbol not associated with an OutputSection (whether linker-defined or not) would be impossible.
>>  Yeah, I think this is a desired behavior.
> 
> Warning would be good, calling it an absolute symbol in the warning is the issue.

The attached patch on top of your patch shows the
problem. _GLOBAL_OFFSET_TABLE_ is not an absolute symbol.

- F5920228: t.diff <https://reviews.llvm.org/F5920228>
- F5920227: msg-9335-260.txt <https://reviews.llvm.org/F5920227>


https://reviews.llvm.org/D44214





More information about the llvm-commits mailing list