[PATCH] D44214: Improve --warn-symbol-ordering.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1063
+      auto *Sec = dyn_cast_or_null<InputSectionBase>(cast<Defined>(Sym)->Section);
+      if (!Sec) {
+        Warning("unable to order absolute symbol");
----------------
ruiu wrote:
> jhenderson wrote:
> > espindola wrote:
> > > This will now fire on symbols the linker defines relative to an output section, no?
> > > 
> > That would be a good thing, right? Attempting to order a symbol not associated with an OutputSection (whether linker-defined or not) would be impossible.
> Yeah, I think this is a desired behavior.
Warning would be good, calling it an absolute symbol in the warning is the issue.


https://reviews.llvm.org/D44214