[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 13:49:36 PDT 2018


ruiu added a comment.

I'm not opposing this patch, but I'm not entirely convinced that we need this feature in the first place. If you need it, please say so.



================
Comment at: ELF/ScriptParser.cpp:432
 
+std::vector<BaseCommand *> ScriptParser::readOverlay() {
+  // VA and LMA expressions are optional, though for simplicity of
----------------
This function is too long.


https://reviews.llvm.org/D44780





More information about the llvm-commits mailing list