[PATCH] D44993: Do not create R_X86_64_32S in dyna relo tbl

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 12:32:30 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Arch/X86_64.cpp:160
   return Type != R_X86_64_PC32 && Type != R_X86_64_32 &&
-         Type != R_X86_64_TPOFF32;
+    Type != R_X86_64_32S && Type != R_X86_64_TPOFF32;
 }
----------------
Please use clang-format. I believe that clang-format would align them vertically like before.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44993





More information about the llvm-commits mailing list