[PATCH] D36351: [lld][ELF] Add profile guided section layout

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 09:40:18 PDT 2018


espindola added inline comments.


================
Comment at: ELF/CallGraphSort.cpp:158
+      warn(Sym->File->getName() +
+           ": unable to order undefined symbol: " + Sym->getName());
+    else if (Sym->isShared())
----------------
This warning is duplicated with what we have in Writer.cpp for --symbol-ordering-file. Could it be merged?


================
Comment at: ELF/CallGraphSort.cpp:277
+void CallGraphSort::generateClusters() {
+
+
----------------
Delete extra empty lines.


https://reviews.llvm.org/D36351





More information about the llvm-commits mailing list