[PATCH] D44627: [CallSiteSplitting] Only record conditions up to the IDom(call site).

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 09:40:17 PDT 2018


junbuml added inline comments.


================
Comment at: test/Transforms/CallSiteSplitting/callsite-split-or-phi.ll:46
 ;CHECK: ret i32 %[[MERGED]]
 define i32 @test_eq_eq_eq(i32* %a, i32 %v, i32 %p) {
 Header:
----------------
We may want to keep this test as it is.  With this patch, the call sites split will take %a, instead of null. null value might be propagated to the callsite later in the pipeline, but there is no reason not to pass the known null value early in the pipeline.  If the callee  has early exit condition with null check. Inliner may have better opportunity to get this callee inlined by passing null. 





https://reviews.llvm.org/D44627





More information about the llvm-commits mailing list