[PATCH] D43347: [ELF][MIPS] Support linking of PIE for MIPS

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/mips-dynamic.s:63
+# EXE-DAG:    0x70000035 MIPS_RLD_MAP_REL     0x{{[0-9A-F]+}}
 # EXE:      ]
 
----------------
I think that this test case, for example, does not really check that
DT_MIPS_RLD_MAP is not emitted for PIE.

Problem is that `*-NEXT` and/or `*-NOT` are not used and check tags are
mixed, what is a bit hard to read.

I would suggest explicitly testing `DynamicSection` twice, one time with
use of `PIE`/`PIE-NEXT` and the second time with `NOPIE`/`NOPIE-NEXT`
to show which tags are produced for each case.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43347