[PATCH] D44960: Prevent llvm-cov from hanging when a symblink doesn't exist.

[Yuke Liao via Phabricator via llvm-commits]

liaoyuke added a comment.

Thanks for the comments, please take another look. Thank you very much!



================
Comment at: include/llvm/Support/FileSystem.h:1036
+        ec = st.getError();
+        return *this;
+      } else if (is_directory(*st)) {
----------------
vsk wrote:
> Could you add a test for this in unittests/Support/Path.cpp?
Just found out there are already a test covering broken symlinks, but unfortunately, that test was artificially manipulated to pass, so it didn't catch the hang, I've modified the test.


Repository:
  rL LLVM

https://reviews.llvm.org/D44960