[PATCH] D44285: Fix computeSymbolSizes SEGFAULT on invalid file

[Teng Qin via Phabricator via llvm-commits]

palmtenor updated this revision to Diff 140025.
palmtenor added a comment.

@aprantl Thanks for the pointing and sorry for the delay. Just added a very simple test to reproduce the crash:)


Repository:
  rL LLVM

https://reviews.llvm.org/D44285

Files:
  lib/Object/SymbolSize.cpp
  test/tools/llvm-symbolizer/sym.test


Index: test/tools/llvm-symbolizer/sym.test
===================================================================
--- test/tools/llvm-symbolizer/sym.test
+++ test/tools/llvm-symbolizer/sym.test
@@ -19,6 +19,9 @@
 
 RUN: llvm-symbolizer -print-address -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck %s
 RUN: llvm-symbolizer -inlining -print-address -pretty-print -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck --check-prefix="PRETTY" %s 
+RUN: dd if=/dev/zero of=%t.zero_file bs=1024 count=1
+RUN: echo "0x1" > %t.input
+RUN: llvm-symbolizer -obj=%t.zero_file < %t.input
 
 #CHECK: some text
 #CHECK: 0x40054d
Index: lib/Object/SymbolSize.cpp
===================================================================
--- lib/Object/SymbolSize.cpp
+++ lib/Object/SymbolSize.cpp
@@ -66,6 +66,10 @@
     Addresses.push_back(
         {O.symbol_end(), Address + Size, 0, getSectionID(O, Sec)});
   }
+
+  if (Addresses.empty())
+    return Ret;
+
   array_pod_sort(Addresses.begin(), Addresses.end(), compareAddress);
 
   // Compute the size as the gap to the next symbol


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44285.140025.patch
Type: text/x-patch
Size: 1079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180328/89f46bb3/attachment.bin>