[PATCH] D44848: Align stubs for external and common global variables to pointer size.

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 17:27:08 PDT 2018


mgrang added inline comments.


================
Comment at: test/Object/X86/align-stub.ll:1
+; RUN: llc %s -mtriple=x86_64-unknown-unknown --relocation-model=pic -filetype=obj -o - \
+; RUN:   | llvm-objdump -r - | FileCheck %s
----------------
Please follow 80 char limit.
See: https://llvm.org/docs/CodingStandards.html#source-code-width

Also -relocation-model=pic instead of --relocation-model=pic.


================
Comment at: test/Object/X86/align-stub.ll:2
+; RUN: llc %s -mtriple=x86_64-unknown-unknown --relocation-model=pic -filetype=obj -o - \
+; RUN:   | llvm-objdump -r - | FileCheck %s
+
----------------
Remove the extraneous space after RUN:


Repository:
  rL LLVM

https://reviews.llvm.org/D44848





More information about the llvm-commits mailing list