[PATCH] D44960: Prevent llvm-cov from hanging when a symblink doesn't exist.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for the patch. Some inline comments --



================
Comment at: include/llvm/Support/FileSystem.h:1036
+        ec = st.getError();
+        return *this;
+      } else if (is_directory(*st)) {
----------------
Could you add a test for this in unittests/Support/Path.cpp?


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:202
     else
-      error("Missing source file", Path);
+      warning("source file doesn't exit, proceeded by ignoring it.", Path);
     return;
----------------
Nitpicks: could you capitalize 'source', and change 'exit' -> 'exist'?


================
Comment at: tools/llvm-cov/CodeCoverage.cpp:222
+      warning(EC.message(), path_before_error_occurs);
+      warning("code coverage results may be incomplete.");
+    }
----------------
Nitpick, please capitalize 'code'.


Repository:
  rL LLVM

https://reviews.llvm.org/D44960