[PATCH] D44850: [PPC64LE] write plt stubs for V2 abi.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 11:54:47 PDT 2018


sfertile added inline comments.


================
Comment at: ELF/Arch/PPC64.cpp:177
+  } else {
+    // FIXME: What we should do, in theory, is get the offset of the function
+    // descriptor in the .opd section, and use that as the offset from %r2 (the
----------------
ruiu wrote:
> Don't you think it's time to remove code for v1 API? It looks like we are doubling the size of the code unless we remove code for v1.
Yes, I have a couple patches waiting to upload, and I think we are probably ready to switch over (almost) all of  the remaining tests to work with the V2 abi.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44850





More information about the llvm-commits mailing list