[PATCH] D44427: [WebAssembly] Add export/import for function pointer table

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/Driver.cpp:308
   Config->StripDebug = Args.hasArg(OPT_strip_debug);
+  Config->Table = getExpose(Args, OPT_import_table, OPT_export_table);
   errorHandler().Verbose = Args.hasArg(OPT_verbose);
----------------
Config members are named after their command line options, so this member should be "ImportTable" or "ExportTable" and have a boolean value.


================
Comment at: wasm/Writer.cpp:42
 static constexpr int kInitialTableOffset = 1;
+static constexpr const char *kFunctionTableName = "__indirect_function_table";
 
----------------
Does it make sense to add `const` to `constexpr`?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44427