[PATCH] D44929: MachineMemOperand: Don't crash when printing custom source values

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 06:59:19 PDT 2018


nhaehnle created this revision.
nhaehnle added reviewers: thegameg, bogner, MatzeB.

Just print out a really obvious explanation of what's wrong.

This won't help with actual MIR, but fixes selection DAG debug output.

Fixes: r327580, https://reviews.llvm.org/D42377


Repository:
  rL LLVM

https://reviews.llvm.org/D44929

Files:
  lib/CodeGen/MachineOperand.cpp


Index: lib/CodeGen/MachineOperand.cpp
===================================================================
--- lib/CodeGen/MachineOperand.cpp
+++ lib/CodeGen/MachineOperand.cpp
@@ -1100,7 +1100,7 @@
           OS, cast<ExternalSymbolPseudoSourceValue>(PVal)->getSymbol());
       break;
     case PseudoSourceValue::TargetCustom:
-      llvm_unreachable("TargetCustom pseudo source values are not supported");
+      OS << "TODO(cannot print TargetCustom pseudo source values)";
       break;
     }
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44929.139916.patch
Type: text/x-patch
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180327/4372019f/attachment.bin>


More information about the llvm-commits mailing list