[PATCH] D44772: [DWARF] Simplify DWARFAddressRange::contains

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D44772#1049017, @jhenderson wrote:

> In https://reviews.llvm.org/D44772#1049012, @JDevlieghere wrote:
>
> > In https://reviews.llvm.org/D44772#1048988, @jhenderson wrote:
> >
> > > LGTM. Any reason you decided not to change `intersects()`?
> >
> >
> > Because we concluded that would not conform to the dwarf standard, right?
>
>
> Right. I was just wondering whether the assert is needed in intersects (after the if, obviously), as well as contains. I think it's fine without it though.


Ah, yes, we should have checked validity before calling intersect. Please add the assertion there as well. Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D44772