[PATCH] D44780: [ELF] - Implement linker script OVERLAYs.

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

I agree that adding this is better than relaxing our section overlap checks for every linker script.

Please also add a test showing that we reject explicit addresses and memory regions for the sections inside the overlay.



================
Comment at: ELF/LinkerScript.h:315
+  // that were seen in overlay descriptions.
+  llvm::DenseSet<OutputSection *> OverlaySections;
 };
----------------
This could be a bit in OutputSection, no?


================
Comment at: ELF/ScriptParser.cpp:451
+    if (Prev)
+      Cmd->LMAExpr = [=] { return Prev->LMAExpr().getValue() + Prev->Size; };
+    else
----------------
Are we missing the alignment?


https://reviews.llvm.org/D44780