[PATCH] D44595: Restructuring LoopRotation.cpp to create Loop Rotation Pass with Loop Rotation Utility Interface

[Jin Lin via Phabricator via llvm-commits]

jinlin added inline comments.


================
Comment at: lib/Transforms/Utils/LoopRotationUtils.cpp:39
+#include "llvm/Transforms/Utils/BasicBlockUtils.h"
+#include "llvm/Transforms/Utils/Local.h"
+#include "llvm/Transforms/Utils/LoopUtils.h"
----------------
jinlin wrote:
> dmgreen wrote:
> > jinlin wrote:
> > > dmgreen wrote:
> > > > I believe this header has moved to Analysis/Utils/Local.h
> > > The header file path is correct.
> > > 
> > > /export/iusers/XXX/v15/llvm/include/llvm=>find  . -name "Local.h"
> > > ./Transforms/Utils/Local.h
> > https://reviews.llvm.org/rL328165 is the commit I was thinking about. It only went in a couple of days ago.
> Hi Dave. 
> 
> Thanks so much for your update. I will update the header file on it.
> 
> Thanks,
> 
> Jin
Hi Dave,

The changes have passed with the tests. However, I don't have privilege to check in the changes. Would you please do me a favor to check in the changes?

Thanks,

Jin 


https://reviews.llvm.org/D44595