[PATCH] D44898: [ELF] Fix incorrect deduplication of MergeSyntheticSection's

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

In https://reviews.llvm.org/D44898#1048634, @ruiu wrote:

> Doesn't this increase lld's memory usage significantly? Mergeable string table tend to be large, and it seems with this patch you keep a copy of an entire section in memory.


True. That would be a reasonable explanation for scylla getting slower.

We could inspect the individual buffers in the StringTableBuilders, but it is not clear if it is worth it.

Maybe the best option is just disabling ICF of synthetic sections?


https://reviews.llvm.org/D44898