[PATCH] D44429: [Support][RFC] MessagePack reader/writer

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 13:04:03 PDT 2018


chandlerc added a subscriber: dblaikie.
chandlerc added a comment.

I haven't really had time to look at this, but it seems somewhat unfortunate to add yet another format like this. =[ I guess I'm surprised that AMD is looking at baking this into their object file format. I'm not sure it makes sense to really consider landing this until the usage of it is at least available for review as well. While having the patches separate is good, I think it would be important to see the actual planned usage before adding all this code.

@dblaikie may have comments about the layering and the unittesting.


Repository:
  rL LLVM

https://reviews.llvm.org/D44429





More information about the llvm-commits mailing list