[PATCH] D44813: Add support for __attribute__(trivial_abi)

Jim Ingham via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 12:30:31 PDT 2018


Thanks for fixing that!

Jim


> On Mar 26, 2018, at 5:52 AM, Pavel Labath via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> labath added a comment.
> 
> In https://reviews.llvm.org/D44813#1048039, @labath wrote:
> 
>> In https://reviews.llvm.org/D44813#1046379, @jingham wrote:
>> 
>>> Pavel, I added you mostly because I'm new to this decorator magic and I wanted to have another pair of eyes to make sure I did that right.
>> 
>> 
>> The decorator looks fine.
> 
> 
> Actually, I spoke too soon. The popen invocation was a bit too posix-y for windows to handle. r328489 should fix that.
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D44813
> 
> 
> 



More information about the llvm-commits mailing list