[PATCH] D44791: [scudo] Fuchsia minimal shared runtime

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: lib/scudo/CMakeLists.txt:26
+if (FUCHSIA)
+  list(APPEND SCUDO_CFLAGS -nostdinc++ -nostdlib++)
+  # TODO(kostyak): remove when stacktraces are split off of RTSanitizerCommon
----------------
phosek wrote:
> cryptoad wrote:
> > phosek wrote:
> > > I think `-nostdlib++` should be in `SCUDO_DYNAMIC_LINK_FLAGS` as `-Wl,-nostdlib++` (unless `add_compiler_rt_runtime` already adds all `CFLAGS` to `LDFLAGS` automatically).
> > I tried that initially but lld (unlike ld) doesn't seem to support it:
> > `ld.lld: error: unknown argument: -nostdlib++`
> > Documentation I could find seems to indicate it as a clang flag (https://clang.llvm.org/docs/ClangCommandLineReference.html)
> Oh my bad, it should be `-nostdlib++` since that flag is actually processed by Clang driver, not by LLD.
However, it should still be in `SCUDO_DYNAMIC_LINK_FLAGS` rather than `SCUDO_FLAGS`.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44791