[PATCH] D44771: [lit] Test /dev/null support on Windows.

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good after reverting the unit test that didn't work.



================
Comment at: utils/lit/tests/Inputs/shtest-shell/dev-null.txt:1
+# Check handling of /dev/null in command line options
+# On windows, it should be redirected to a temp file.
----------------
New test looks good, thanks!


================
Comment at: utils/lit/tests/unit/TestRunner.py:108
+        else:
+            self.assertFalse('/dev/null' in value[2].strip())
+            self.assertFalse('/dev/null' in value[3].strip())
----------------
This test still fails because the parser doesn't do the replacement. You need to revert changes to this file and probably testrunner-custom-parsers/test.txt before committing or tests will fail on Windows.


Repository:
  rL LLVM

https://reviews.llvm.org/D44771