[PATCH] D44868: [SLP] Distinguish "demanded and shrinkable" from "demanded and not shrinkable" values when determining the minimum bitwidth

[Haicheng Wu via Phabricator via llvm-commits]

haicheng added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4337
+      llvm::all_of(TreeRoot, [&](Value *R) {
+        return isa<GetElementPtrInst>(*R->user_begin());
+      })) {
----------------
ABataev wrote:
> What if only begin use is GEP and others are not?
I think we've checked earlier that there is only one use here.


================
Comment at: test/Transforms/SLPVectorizer/AArch64/ext-trunc.ll:1
+; RUN: opt -S -slp-vectorizer -instcombine < %s | FileCheck %s
+
----------------
ABataev wrote:
> 1. Commit this test separately as NFC with checks for the current version of the compiler.
> 2. Generate test checks using `utils/update_test_checks.py`
I will commit the separately.


Repository:
  rL LLVM

https://reviews.llvm.org/D44868