[PATCH] D44898: [ELF] Fix incorrect deduplication of MergeSyntheticSection's

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 08:54:04 PDT 2018


espindola added inline comments.


================
Comment at: test/ELF/icf-not-equal-merged-sections.s:6
+
+# CHECK-NOT: selected section <internal>:(.rodata)
+
----------------
The test would be a bit more dependable if you checked the content of the output with objdump/readelf/readobj.

As written the test would still pass if we changed the icf message and regressed this fix.



https://reviews.llvm.org/D44898





More information about the llvm-commits mailing list