[PATCH] D44791: [scudo] Fuchsia minimal shared runtime

Mon Mar 26 07:55:43 PDT 2018

cryptoad added inline comments.

================
Comment at: lib/scudo/CMakeLists.txt:26
+if (FUCHSIA)
+  list(APPEND SCUDO_CFLAGS -nostdinc++ -nostdlib++)
+  # TODO(kostyak): remove when stacktraces are split off of RTSanitizerCommon
----------------
phosek wrote:
> I think `-nostdlib++` should be in `SCUDO_DYNAMIC_LINK_FLAGS` as `-Wl,-nostdlib++` (unless `add_compiler_rt_runtime` already adds all `CFLAGS` to `LDFLAGS` automatically).
I tried that initially but lld (unlike ld) doesn't seem to support it:
`ld.lld: error: unknown argument: -nostdlib++`
Documentation I could find seems to indicate it as a clang flag (https://clang.llvm.org/docs/ClangCommandLineReference.html)

Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44791