[PATCH] D44818: [LoopUnroll] Fix dangling pointers in SCEV

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 02:38:41 PDT 2018


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Makes sense, LGTM.



================
Comment at: lib/Transforms/Utils/LoopUnroll.cpp:506
+  // We are going to make changes to this loop. SCEV may be keeping cached info
+  // about it, in patricular about backedge taken count. The changes we make
+  // are guaranteed to invalidate this information for our loop. It is tempting
----------------
nit: typo


https://reviews.llvm.org/D44818





More information about the llvm-commits mailing list