[llvm] r328478 - [ARM] Simplify constructing the ARMArchFeature string. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 01:41:10 PDT 2018


Author: mstorsjo
Date: Mon Mar 26 01:41:10 2018
New Revision: 328478

URL: http://llvm.org/viewvc/llvm-project?rev=328478&view=rev
Log:
[ARM] Simplify constructing the ARMArchFeature string. NFC.

Differential Revision: https://reviews.llvm.org/D44819

Modified:
    llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp

Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp?rev=328478&r1=328477&r2=328478&view=diff
==============================================================================
--- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp (original)
+++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp Mon Mar 26 01:41:10 2018
@@ -140,24 +140,21 @@ std::string ARM_MC::ParseARMTriple(const
     ARMArchFeature = (ARMArchFeature + "+" + ARM::getArchName(ArchID)).str();
 
   if (TT.isThumb()) {
-    if (ARMArchFeature.empty())
-      ARMArchFeature = "+thumb-mode,+v4t";
-    else
-      ARMArchFeature += ",+thumb-mode,+v4t";
+    if (!ARMArchFeature.empty())
+      ARMArchFeature += ",";
+    ARMArchFeature += "+thumb-mode,+v4t";
   }
 
   if (TT.isOSNaCl()) {
-    if (ARMArchFeature.empty())
-      ARMArchFeature = "+nacl-trap";
-    else
-      ARMArchFeature += ",+nacl-trap";
+    if (!ARMArchFeature.empty())
+      ARMArchFeature += ",";
+    ARMArchFeature += "+nacl-trap";
   }
 
   if (TT.isOSWindows()) {
-    if (ARMArchFeature.empty())
-      ARMArchFeature = "+noarm";
-    else
-      ARMArchFeature += ",+noarm";
+    if (!ARMArchFeature.empty())
+      ARMArchFeature += ",";
+    ARMArchFeature += "+noarm";
   }
 
   return ARMArchFeature;




More information about the llvm-commits mailing list