[PATCH] D44282: [PR16756] JumpThreading: explicitly update SSA rather than use SSAUpdater.

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2013
+
+    // We found a use of I outside of BB - ee need to rename all uses of I that
+    // are outside its block to be uses of the appropriate PHI node etc.
----------------
typo: s/ee/we/


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2036
 
+  DominatorTree *DT = &DDT->flush();
+  SSAUpdate.RewriteAllUses(DT);
----------------
Why do you need to flush the dominator here? please add a comment.


Repository:
  rL LLVM

https://reviews.llvm.org/D44282