[PATCH] D44791: [scudo] Fuchsia minimal shared runtime

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/scudo/CMakeLists.txt:24
+  list(APPEND SCUDO_DYNAMIC_LIBS unwind_shared)
+endif()
+
----------------
phosek wrote:
> You could add `RTSanitizerCommonCoverage`, `RTUbsan`, `RTUbsan_cxx` to a variable (e.g. `${SCUDO_EXTRA_OBJECT_LIBS}`) and `${SANITIZER_CXX_ABI_LIBRARY}` to `${SCUDO_DYNAMIC_LIBS}` in the else branch and then you don't need the two different branches for `add_compiler_rt_runtime(clang_rt.scudo ...)` below.
Will do.


================
Comment at: lib/scudo/CMakeLists.txt:57
                 RTSanitizerCommonLibc
                 RTSanitizerCommonCoverage
                 RTInterception
----------------
phosek wrote:
> Is this needed? I see it being included in `STATIC` library for all platforms and `SHARED` library for everything but Fuchsia. Is that correct?
That is correct.
ubsan_init.cc makes use of __sanitizer::InitializeCoverage so everything that uses UBsan has to include coverage.
Scudo doesn't need coverage or symbolizer, which are intertwined within RTSanitizerCommon, so I am in the process of splitting them both in order to have a thin runtime that isn't pulling in extraneous dependencies from sanitizer_common. 


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44791