[PATCH] D44853: [AArch64] Change std::sort to llvm::sort in response to r327219

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 20:39:16 PDT 2018


rengolin requested changes to this revision.
rengolin added a comment.
This revision now requires changes to proceed.

I don't like this being on by default. I get it it uses `EXPENSIVE_CHECKS`, but still, most developers use Debug/Asserts builds.

I think it's fine to have the `llvm::sort` in tree, but the patches that make use of it should be local, as they're use for specific investigations.

Either that, or we replace *all* `std::sort` for `llvm:sort` and not just this one particular case.


Repository:
  rL LLVM

https://reviews.llvm.org/D44853





More information about the llvm-commits mailing list