[PATCH] D44730: [ELF] - Do not forget to expand the memory region.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 19:29:15 PDT 2018


espindola accepted this revision.
espindola added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: test/ELF/linkerscript/memory-region-alignment.test:12
+    *(.foo)
+  } > ram
+}
----------------
Can you avoid orphan sections?


================
Comment at: test/ELF/linkerscript/memory-region-alignment.test:19
+# CHECK: Name: .foo
+# CHECK: Address: 0x8
+# CHECK: Offset: 0x1008
----------------
Can you use CHECK-NEXT?


https://reviews.llvm.org/D44730





More information about the llvm-commits mailing list