[PATCH] D44718: [AMDGPU] Define code object identification string used in AMDHSA runtimes.

Brian Sumner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 12:26:58 PDT 2018

Previous message: [PATCH] D44718: [AMDGPU] Define code object identification string used in AMDHSA runtimes.
Next message: [PATCH] D44718: [AMDGPU] Define code object identification string used in AMDHSA runtimes.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

b-sumner added a comment.

LGTM, but I'd rather use '+' instead of ',' for the features.


https://reviews.llvm.org/D44718

Previous message: [PATCH] D44718: [AMDGPU] Define code object identification string used in AMDHSA runtimes.
Next message: [PATCH] D44718: [AMDGPU] Define code object identification string used in AMDHSA runtimes.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list