[PATCH] D44821: [NFC] OptPassGate extracted from OptBisect

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/OptBisect.h:19-21
+#include "llvm/Analysis/CallGraphSCCPass.h"
+#include "llvm/Analysis/LoopInfo.h"
+#include "llvm/Analysis/RegionInfo.h"
----------------
andrew.w.kaylor wrote:
> fedor.sergeev wrote:
> > Hmm.. can we avoid adding these headers and add forward declarations of all the necessary classes, please?
> > (the problem of layering has been just recently discussed on llvm-dev@)
> Forward declaration doesn't really fix the layering problem. We really need to not use these classes.
> 
> The trouble is that at least in the OptBisect case we don't really want to build the description unless we're doing OptBisect, but we can't build the description for CallGraphSCC without having the layering problem.
Okey, layering aside, forward declarations instead of Analysis headers would still be preferable here.


https://reviews.llvm.org/D44821