[PATCH] D44771: [lit] Test /dev/null support on Windows.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 23 11:45:14 PDT 2018
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
I ran the tests, and the unit tests don't pass because the /dev/null replacement happens much later during test execution, not command parsing. Unit testing the text executor would require much more faking/mocking than is really worth it. I would be comfortable making this change include a revert of https://reviews.llvm.org/rL328157. That will exercise the new replacement enough.
Repository:
rL LLVM
https://reviews.llvm.org/D44771
More information about the llvm-commits
mailing list