[PATCH] D44811: DWARF] DWARF v5: .debug_rnglists: adding support for DW_RLE_offset_pair and DW_RLE_base_address

[David Blaikie via llvm-commits]

On Fri, Mar 23, 2018 at 11:18 AM Wolfgang Pieb via Phabricator <
reviews at reviews.llvm.org> wrote:

> wolfgangp added inline comments.
>
>
> ================
> Comment at: lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp:134
> +                           *OffsetPtr - 1);
> +      uint64_t Base = Data.getAddress(OffsetPtr);
> +      CurrentRanges.push_back(RangeListEntry{EntryOffset, Encoding, Base,
> 0});
> ----------------
> dblaikie wrote:
> > Some of our range dumping can now print which section an address refers
> to - should we do that for this range dumping? If so, we'd need to extract
> the section info here, I think?
> Currently the section is displayed when we're dumping the specific ranges
> a DIE refers to (DW_AT_ranges attribute). When we're dumping the contents
> of the entire .debug_ranges section we don't do it. Do you think we should
> do it there too?
>

Ah, fair - thanks for pointing out the distinction.

I think at some point, it might make sense to dump the sections here too.
But if we don't do it for the existing debug_ranges right now, that's not
really an inconsistency/bug, just missing feature.


> The full support for .debug_rnglists will turn the rangelists into
> DWARFAddressRangesVectors, so it will behave the same as the current
> implementation in this respect.
>

*nod* that'll be good


>
>
> https://reviews.llvm.org/D44811
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180323/ca774fe6/attachment.html>