[PATCH] D44415: [PM][FunctionAttrs] add NoUnwind attribute inference to PostOrderFunctionAttrs pass

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev marked an inline comment as not done.
fedor.sergeev added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1128
+    // All the attributes currently available for inference are good to go
+    // with this function unless explicitly skipped.
+    llvm::copy_if(
----------------
jlebar wrote:
> jlebar wrote:
> > Suggest moving the comment up one line and saying something like
> > 
> > ```For each attribute still in InferInSCC that doesn't skip F, check that the instructions in F are valid.```
> Sorry, I think the reworded comment is still unclear.
> 
> If you're willing to tell me what you don't like about the suggestion I made earlier, perhaps we can come up with something we both like.
Mostly I didnt like "instructions are valid" part, which is not what we are checking for.
If you dont like my last variant - please, suggest your own that talks about attribute, not instruction.


Repository:
  rL LLVM

https://reviews.llvm.org/D44415